Skip to content

Reject empty old_string in edit tool #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

Reject empty old_string in edit tool #1709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/anthropic/lib/tools/agent_toolset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,8 @@ async def edit(file_path: str, old_string: str, new_string: str, replace_all: Op
target = resolve_path(ctx, file_path)
except ValueError as e:
raise ToolError(f"edit: {e}") from e
if old_string == "":
raise ToolError("edit: old_string must not be empty")
try:
# stat() before any open(): the size cap stops a multi-GB file from
# OOM'ing the runner, and is_file() rejects FIFOs/devices/dirs
Expand Down