Fix unhelpful error message for malformed JSON in streaming tool use#1335
Open
Christian-Sidak wants to merge 2 commits intoanthropics:mainfrom
Open
Fix unhelpful error message for malformed JSON in streaming tool use#1335Christian-Sidak wants to merge 2 commits intoanthropics:mainfrom
Christian-Sidak wants to merge 2 commits intoanthropics:mainfrom
Conversation
The docstring was copy-pasted from the sync BetaAbstractMemoryTool without updating for async usage. This fixes: - Base class: BetaAbstractMemoryTool -> BetaAsyncAbstractMemoryTool - Method definitions: def -> async def - Client: Anthropic() -> AsyncAnthropic() - Wrap usage in async def main() / asyncio.run(main()) Fixes anthropics#1290
Wrap the from_json() call in the non-beta streaming path with the same try-except that already exists in the beta path, so users get a clear error message indicating the issue is malformed tool parameter JSON from the model, rather than a raw jiter parser error with no context. Fixes anthropics#1265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_json()call in_messages.pywith the sametry-except ValueErrorthat already exists in_beta_messages.py, so users get a clear, actionable error message when the model emits malformed tool parameter JSON during streamingProblem
When using
client.messages.stream()with tools, if the model emits malformed JSON in aninput_json_deltaevent, users see a raw parser error likeValueError: expected ident at line 1 column 11with no context about what went wrong or what to do.The beta path (
_beta_messages.py) already handles this with a helpful message. The non-beta path (_messages.py) was missing the same handling.Fix
6-line change: wrap the
from_jsoncall at line 480 of_messages.pywith the same try-except pattern from_beta_messages.py. Zero behavior change for valid JSON.Fixes #1265