Skip to content

feat: api performance optimized - #5307

Draft
mayankansys wants to merge 3 commits into
mainfrom
refactor/eager_imports
Draft

feat: api performance optimized#5307
mayankansys wants to merge 3 commits into
mainfrom
refactor/eager_imports

Conversation

@mayankansys

Copy link
Copy Markdown
Collaborator

Context

What was the situation or problem before this change?

Change Summary

What changes were made?

Rationale

Why was this approach taken?

Impact

What parts of the system or workflows are affected?

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Gobot1234 Gobot1234 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in it's current state will completely remove type information from all of the API. You'll need to add an if TYPE_CHECKING block with the imports still

@mayankansys

Copy link
Copy Markdown
Collaborator Author

Check the working of the autocomplete.

@mayankansys

Copy link
Copy Markdown
Collaborator Author

This in it's current state will completely remove type information from all of the API. You'll need to add an if TYPE_CHECKING block with the imports still

@Gobot1234 Thanks for pointing out, I was currently working on it & it will be resolved in the upcoming commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants