fix: always include background parameter in task tool schema - #45342
Closed
OgPenguu wants to merge 1 commit into
Closed
fix: always include background parameter in task tool schema#45342OgPenguu wants to merge 1 commit into
OgPenguu wants to merge 1 commit into
Conversation
When OPENCODE_EXPERIMENTAL_BACKGROUND_SUBAGENTS=true, the jsonSchema
field was set to undefined, hiding the background parameter from the
tool schema. Agents couldn't see the parameter and never used it.
Changed from:
jsonSchema: flags.experimentalBackgroundSubagents
? undefined
: ToolJsonSchema.fromSchema(BaseParameters)
To:
jsonSchema: ToolJsonSchema.fromSchema(Parameters)
This always includes the full Parameters schema (which has the background
field) regardless of the experimental flag. The flag still controls the
description hint and the execute function behavior.
Co-authored-by: OpenChamber <noreply@openchamber.dev>
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #45345
Type of change
What does this PR do?
When
OPENCODE_EXPERIMENTAL_BACKGROUND_SUBAGENTS=true, thebackgroundparameter on the task tool is set toundefinedin the schema, making it invisible to agents. They can't discover it and never use background execution.The fix changes line 366 in
packages/opencode/src/tool/task.tsfrom:to:
This always includes the full parameter schema (which contains
background) regardless of the flag. The flag still controls the description hint and execute function behavior, so the feature gating remains intact.How did you verify your code works?
OPENCODE_EXPERIMENTAL_BACKGROUND_SUBAGENTS=truebackgroundparameter appears in the tool schema (inspected via compiled output)Screenshots / recordings
N/A - CLI tool, no UI changes.
Checklist