refactor(core): centralize manual compaction lifecycle - #45335
Open
kitlangton wants to merge 1 commit into
Open
Conversation
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Manual compaction currently splits one lifecycle between the Session runner and Compaction. The runner publishes the start, passes
started: truewith a history snapshot, and handles cancellation and defects outside the module that performs the summary.What Changes
SessionCompaction.runPendingnow owns selection, delivery, summary execution, and settlement of an eligible manual control. The runner keeps its existing safe-step-boundary decisions and only asks whether a control was consumed.This removes
ManualInput, thestartedhandshake, and the runner's compaction settlement helper: 50 fewer runner lines and 20 fewer production lines overall. Manual tests now admit durable controls rather than calling an unqueued execution path; they retain usage, event ordering, fork-cache, hook-isolation, and successful-settlement assertions.Scope
Internal Core refactor following #45294. No new service, durable event, HTTP contract, or compaction policy. The interrupt/wait Location change is a separate PR.
Verification
git diff --checkpassed. Oxlint reported no errors and two inheritedconsistent-returnwarnings, one in code moved from the runner.