fix(opencode): omit empty apply patch move path - #45329
Open
altendky wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: Related PR:
Also potentially related (similar pattern fixes):
The most immediately related is #45316, which also deals with apply_patch move behavior. You may want to verify these aren't addressing overlapping concerns or if they should be coordinated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #45275
Type of change
What does this PR do?
Non-move
apply_patchchanges includedmovePath: undefinedin permission metadata. Pending permission requests then failed JSON encoding when clients calledGET /permission.This omits
movePathunless a patch actually moves a file. It keeps the fix local to the v1 apply-patch metadata producer and preserves move metadata when present.How did you verify your code works?
The regression test reproduced
Expected JSON valuewithmetadata.files[0].movePathset toundefinedbefore the fix. The fulltest/tool/apply_patch.test.tssuite passes with 28 tests, package typecheck passes, and the pre-push repository typecheck completed 30 of 30 tasks successfully.Screenshots / recordings
Not a UI change.
Checklist
If you do not follow this template your PR will be automatically rejected.