fix(tui): prevent overlapping frames in update preflight animation - #39045
Open
Zeraphim wants to merge 18 commits into
Open
fix(tui): prevent overlapping frames in update preflight animation#39045Zeraphim wants to merge 18 commits into
Zeraphim wants to merge 18 commits into
Conversation
The update preflight footer's frame callback was returning an immediately-resolved promise after batch() and tick() signal updates, allowing the renderer to proceed to the next frame before SolidJS had flushed its reactive microtasks. This caused the renderer to write terminal escape sequences for frame N+1 while SolidJS was still applying frame N's updates, resulting in overlapping, corrupted output during long service startups. The fix makes the frame callback async and yields to the microtask queue after batched signal updates, ensuring SolidJS flushes all reactive effects before the renderer begins the next paint cycle.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Zeraphim
marked this pull request as ready for review
July 27, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #38595
Type of change
What does this PR do?
The update preflight footer frame callback returns an immediately-resolved promise after batch() and tick() signal updates, allowing the renderer to proceed to the next frame before SolidJS has flushed its reactive microtasks. This causes terminal escape sequences from two renders to interleave during long service startups.
The fix makes the frame callback async and yields to the microtask queue after all batched signal and tick updates via queueMicrotask. This gives SolidJS a chance to flush pending reactive updates before the renderer begins the next paint cycle.
How did you verify your code works?
The fix is a direct code fix to the frame callback in packages/cli/src/services/update-preflight.tsx. The async frame callback now properly awaits a microtask after all signal/tick updates before returning.
Screenshots / recordings
No screenshots available - reproduction requires a 110+ second background service startup with version mismatch.
Checklist