refactor(app): remove promoting workaround#36426
Open
nokados wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A — cleanup of workaround from #34466
Type of change
What does this PR do?
Commit e34822d (#34466) added an in-memory
promotingstate tobridge the gap between
promote()clearingstore.draftandnavigate()updating the session ID.Commit ea982c3 (#36182) wrapped
promote()+navigate()instartTransition, which batches both updates atomically. Thepromotingworkaround is no longer needed —scope()switchesdirectly from
store.drafttosaved.session[session]with nointermediate state.
How did you verify your code works?
Verified no flicker on both
latestanddevWeb UI channels whensending the first message in a new session with a non-default model
selected.
Screenshots / recordings
Checklist