fix(client): allow large sse events#36368
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: I found one potentially related PR: PR #33289: fix(app): prevent web client freeze from delta event bursts and SSE reconnect loops This PR addresses SSE-related issues with event handling and reconnect loops, which could be tangentially related to the buffer size issue being fixed in PR #36368. However, it appears to be focused on a different aspect (preventing freezes and reconnect loops) rather than directly addressing the buffer size limitation for large SSE events. The current PR (#36368) is specifically about raising the SSE frame buffer from 1 MiB to 32 MiB to support large tool success events. This appears to be a targeted fix distinct from the reconnect loop handling in #33289. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Hi @kitlangton — pinging for a review on this PR. It references #36343 and the automated checks are passing, but the "needs:issue" label appears stuck because the GitHub-linked issue is not showing up in the sidebar. Could you confirm the issue is linked (or manually link it) and take a look when you have a moment? Thanks! |
Closes #36343
Issue for this PR
Closes #36343
Type of change
What does this PR do?
Raises the generated Promise client's SSE frame buffer from 1 MiB to 32 MiB so supported large tool success events, such as image read events, do not disconnect
/api/eventsubscribers withMalformedResponse.The new ceiling still bounds malformed/unbounded SSE frames, but aligns the client with V2's supported media ingest path where a valid encoded image event can exceed 1 MiB.
How did you verify your code works?
event.subscribe.bun test test/promise.test.tsfrompackages/client.git diff --check.bun run generatefrompackages/client; blocked locally by dependency resolution:Cannot find module '@effect/platform/Cookies'from@effect/platform-node.bun test test/generate.test.tsfrompackages/httpapi-codegen; blocked locally because this worktree has no installedeffectpackage.Screenshots / recordings
N/A
Checklist