fix: sync reveal-menu i18n keys across all locales#36293
Open
AbdoKnbGit wants to merge 1 commit into
Open
Conversation
AbdoKnbGit
force-pushed
the
fix/reveal-menu-i18n-v2
branch
from
2daa844 to
1409b13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36292
Type of change
What does this PR do?
Adds the missing
session.header.reveal.*translation keys to the non-English locales. These keys were added to the English locale (en.ts) in a prior change but were not propagated to the other locale files, causing the i18n parity test to fail.How did you verify your code works?
Ran
bun test src/i18n/parity.test.tsfrompackages/app— all 4 tests pass.Checklist