fix(session): agent.model and agent.variant config ignored in handleSubtask#36281
Open
naveen9036 wants to merge 2 commits into
Open
fix(session): agent.model and agent.variant config ignored in handleSubtask#36281naveen9036 wants to merge 2 commits into
naveen9036 wants to merge 2 commits into
Conversation
- Move taskAgent fetch before taskModel resolution so the agent's configured model is available when deciding which model to use - Add taskAgent.model as middle tier in the fallback chain: task.model > agent.model > parent session model - Use taskAgent.variant as preference over parent session variant Closes anomalyco#21632 Re-fixes anomalyco#21952
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36250
Type of change
What does this PR do?
Fixes two bugs in
handleSubtaskwhereagent.modelandagent.variantconfigured inopencode.jsonare silently ignored when a subagent is spawned.taskAgentwas being fetched aftertaskModelwas already resolved, meaning the agent's configured model was never consulted.variantwas hardcoded to the parent session's variant, ignoringagent.variant.Fix: Moved the
taskAgentfetch beforetaskModelresolution, addedtaskAgent.modelto the fallback chain, and prioritizedtaskAgent.variantover the parent session's variant.How did you verify your code works?
Tested locally with Ollama to ensure the subagent correctly switches to the configured model from
opencode.json. Also verified thatbun run typecheckpasses cleanly with 0 errors.Screenshots / recordings
N/A (Backend logic fix, no UI changes)
Checklist