fix(core): surface background subagent completions in TUI#36242
Open
CountClaw wants to merge 1 commit into
Open
fix(core): surface background subagent completions in TUI#36242CountClaw wants to merge 1 commit into
CountClaw wants to merge 1 commit into
Conversation
Background subagent injectCompletion published synthetic messages with text only. The V2 TUI filters synthetic rows without a description, so parent transcripts never showed completion or failure notices. Pass a concise human-readable description on synthetic admission while keeping the structured XML body for model context. Closes anomalyco#35063
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background subagent completion injection published synthetic parent-session messages with
textonly. The V2 TUI only renders synthetic rows whendescriptionis non-empty (packages/tui/src/routes/session/rows.ts), so parent transcripts never showed the explicit completion/failure notice.Changes
descriptiononsession.syntheticfromSubagentTool.injectCompletiontextfor model contextCloses #35063
Test plan
packages/core/test/tool-subagent.test.tsassertionsbun test --timeout 60000 test/tool-subagent.test.tsinpackages/core(local Windows run hit pre-existing tmpdir EBUSY flakes; logic covered by assertion update)