fix(opencode): resolve explicit config instructions#30270
Open
849261680 wants to merge 4 commits into
Open
Conversation
849261680
force-pushed
the
fix/config-instruction-origin
branch
from
64a71e7 to
7641a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30233
Type of change
What does this PR do?
When project config scanning is disabled, explicit config files can still be loaded through OPENCODE_CONFIG, but relative instruction paths were resolved from the global config directory. This keeps instruction source metadata while merging config, then resolves relative instruction files from the config source that declared them.
How did you verify your code works?
bun test test/session/instruction.test.tsbun test test/config/config.test.tsbun typecheckfrompackages/opencodebun turbo typecheckScreenshots / recordings
N/A, no UI change.
Checklist
If you do not follow this template your PR will be automatically rejected.