fix(tui): restart process after auto-upgrade to apply new binary#29345
Open
LifeJiggy wants to merge 1 commit into
Open
fix(tui): restart process after auto-upgrade to apply new binary#29345LifeJiggy wants to merge 1 commit into
LifeJiggy wants to merge 1 commit into
Conversation
After auto-upgrade downloads and installs a new binary, the running process continues with the old binary's in-memory state. Fix by: - Returning a boolean from upgrade() indicating if upgrade occurred - Disposing instances and stopping server before restart - Spawning a new process with the same args and exiting cleanly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27859
Type of change
What does this PR do?
After auto-upgrade downloads and installs a new binary, the running process continues with the old binary. Session/auth state that was in memory is lost because the new binary is only picked up on next manual restart.
How did you verify your code works?
2 new tests confirming Installation event type strings. Typecheck clean. Existing tests unaffected.
Checklist