fix(tui): handle non-string path.isAbsolute inputs gracefully#29342
Open
LifeJiggy wants to merge 1 commit into
Open
fix(tui): handle non-string path.isAbsolute inputs gracefully#29342LifeJiggy wants to merge 1 commit into
LifeJiggy wants to merge 1 commit into
Conversation
- Add Filesystem.isAbsolutePath() type-safe wrapper - Guard resolveThreadDirectory against non-string project arg - Guard plugin resolveRoot against non-string root input - Add runtime type check in config file path resolution - Add tests for safe path handling with numeric/null/object inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29164
Type of change
What does this PR do?
TUI crashes when a non-string value (numeric config, null, object) is passed to path.isAbsolute() in resolveThreadDirectory or plugin resolveRoot. Node's path.isAbsolute() throws on non-string input.
How did you verify your code works?
8 new tests covering numeric, null, object, and boolean inputs to path resolution functions — all pass. Existing tests unaffected.
Checklist