fix(app): open selected file from file tree#29337
Closed
YOMXXX wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29299
Type of change
What does this PR do?
The desktop header open button always used the project directory as its target. After selecting a file in the right file tree, clicking the open button still opened the project root instead of the selected file.
This PR tracks the most recently selected file from the side-panel file tree, keeps that selection in sync when an active file tab changes, and resolves the header open/copy target to that file path. Without a selected file, the button still falls back to the project directory.
How did you verify your code works?
cd packages/app && PATH="$HOME/.bun/bin:$PATH" bun test src/components/session/session-header-path.test.ts src/pages/session/helpers.test.ts src/components/file-tree.test.tscd packages/app && PATH="$HOME/.bun/bin:$PATH" bun typecheckgit diff --checkcd packages/app && PATH="$HOME/.bun/bin:$PATH" bun test --preload ./happydom.ts ./srcPATH="$HOME/.bun/bin:$PATH" .husky/pre-pushScreenshots / recordings
Not included; this changes the open target behavior without changing visible layout.
Checklist