refactor: break SessionPrompt/TaskTool cycle via ctx injection#21948
Merged
kitlangton merged 3 commits intodevfrom Apr 10, 2026
Merged
refactor: break SessionPrompt/TaskTool cycle via ctx injection#21948kitlangton merged 3 commits intodevfrom
kitlangton merged 3 commits intodevfrom
Conversation
TaskTool no longer imports SessionPrompt at runtime. Instead, prompt operations (cancel, resolvePromptParts, prompt) are injected via ctx.extra.promptOps by the caller. This inverts the dependency so the service graph is acyclic, unblocking future single-runtime composition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import typeonlyctx.extra.promptOpsby the caller (SessionPrompt)SessionPrompt → ToolRegistry → TaskTool → SessionPromptcycleTest plan