convert skill tool to Tool.defineEffect#21936
Merged
kitlangton merged 2 commits intodevfrom Apr 10, 2026
Merged
Conversation
kitlangton
force-pushed
the
kit/tool-effect-skill
branch
3 times, most recently
from
edc2eb4 to
cc09fe6
Compare
kitlangton
force-pushed
the
kit/tool-effect-skill
branch
from
cc09fe6 to
940b568
Compare
kitlangton
force-pushed
the
kit/tool-effect-skill
branch
from
940b568 to
2fadede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillToolfromTool.definetoTool.defineEffectpatternSkill.available,Skill.get,Skill.all,ctx.ask,Ripgrep.files) inEffect.promiseEffect.orDiebeforeEffect.runPromisein the execute pipelineSkillToolEffect in registry before passing toTool.init.init()Test plan
bun run typecheckpasses (no new errors)bun run test test/tool/skill.test.ts— all 3 tests pass