test(app): stabilize windows theme select e2e#21919
Draft
HaleTom wants to merge 1 commit intoanomalyco:devfrom
Draft
test(app): stabilize windows theme select e2e#21919HaleTom wants to merge 1 commit intoanomalyco:devfrom
HaleTom wants to merge 1 commit intoanomalyco:devfrom
Conversation
Target the selected theme option explicitly and use a forced click in the flaky settings localStorage test so Windows Playwright does not timeout on an unstable select item. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21915
Related: #17093
Blocked by / helping unblock: #21233, #21559
Type of change
What does this PR do?
This stabilizes the flaky Windows Playwright interaction in
packages/app/e2e/settings/settings.spec.tsforchanging theme persists in localStorage.The test now targets the resolved theme option, waits for it to be visible, and uses a forced click for that specific popup interaction instead of relying on a normal click against an element that Windows CI reports as unstable.
Why does this need a focused PR?
#17093is the broad flaky-CI umbrella, but this timeout is specific enough to isolate: one Windows Playwright failure in one settings selector path.That matters because the same flaky Windows e2e is blocking unrelated work, including
#21233, and it has also been blocking confidence on#21559. Keeping this PR narrowly scoped makes it easier to land as an unblocker without dragging other changes along.How did you verify your code works?
PLAYWRIGHT_BROWSERS_PATH="/home/ravi/code/opencode/wrap-links/.playwright-browsers" PLAYWRIGHT_WORKERS=2 bun test:e2e:local -- e2e/settings/settings.spec.ts -g "changing theme persists in localStorage" --repeat-each=55 passedChecklist