fix: enforce skill deny pattern filtering#21881
Closed
saurav-shakya wants to merge 3 commits intoanomalyco:devfrom
Closed
fix: enforce skill deny pattern filtering#21881saurav-shakya wants to merge 3 commits intoanomalyco:devfrom
saurav-shakya wants to merge 3 commits intoanomalyco:devfrom
Conversation
…rflow Two fixes in this commit: ### 1. Render <think> tags as reasoning blocks at display layer Models like GLM-5 embed reasoning in raw <think>...</think> tags within text parts. Previously these were displayed as raw HTML to the user. **Approach:** Parse and render <think> / <thinking> tags at the display layer (TUI, Web UI, CLI) rather than stripping them from the message storage. This preserves the full model output for multi-turn context while giving users clean, styled reasoning blocks. **Changes:** - packages/util/src/think.ts -- Shared utility: stripThinkTags(), splitThinkBlocks() with regex matching both <think> and <thinking> variants - packages/opencode/src/util/format.ts -- Same utilities for the core package - packages/opencode/src/cli/cmd/tui/routes/session/index.tsx -- TextPart renders think blocks with dim/italic/bordered styling matching ReasoningPart - packages/ui/src/components/message-part.tsx -- TextPartDisplay renders think blocks in <div data-component="reasoning-part"> - packages/opencode/src/cli/cmd/run.ts -- CLI strips think tags from output, shows reasoning with --thinking flag ### 2. Fix MCP MaxListeners overflow with many servers When 7+ stdio-based MCP servers are configured, the default Node.js EventEmitter limit of ~10 is exceeded. Each StdioClientTransport spawns a child process and adds listeners to its stdin/stdout/stderr pipes. The MCP protocol layer also sends many concurrent requests (getPrompt, listTools, etc.) that each add a 'drain' listener. **Fix:** Dynamically calculate the needed listener limit based on the number of configured local MCP servers and increase both EventEmitter.defaultMaxListeners and process stream limits before connecting. **Changes:** - packages/opencode/src/mcp/index.ts -- Count local MCP servers, set EventEmitter.defaultMaxListeners and process stream limits proportionally ## Related Issues - Fixes anomalyco#16903 (GLM-5 thinking output pollution) - Fixes anomalyco#11439 (think tag rendering regression from removal of extractReasoningMiddleware) - Related: anomalyco#4033, anomalyco#7779
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21793
Type of change
What does this PR do?
This fixes a bug where permission.skill pattern rules (for example lark-*: deny) were not fully enforced in skill exposure.
Changes made:
Why this works:
How did you verify your code works?
I verified by:
Screenshots / recordings
N/A (non-UI change)
Checklist