feat(friendli): add GLM-5.3-Flash provider support - #5605
Open
Lee-Si-Yoon wants to merge 5 commits into
Open
Conversation
base_model = zhipuai/glm-5.3-flash (override-only file). reasoning_options: effort [low, high, max] per chat_template.jinja (reasoning_effort defaults to max unless low/high passed). cost: input $0.15, output $0.5, cache_read $0.03 /MTok.
Contributor
Action items
|
Friendli /v1/models reports input_modalities: ["text"] for zai-org/GLM-5.3-Flash even though the upstream model is multimodal. Override modalities instead of inheriting image/video/pdf input. anomalyco#5605
Vision-capable upstream checkpoint; Friendli endpoint will serve image input. Keep modalities override minimal instead of inheriting video/pdf from the lab entry. anomalyco#5605
Contributor
|
The PR has a concrete modalities contradiction that needs fixing before merge. ## Action items
- **[medium] [possible mistake]** `providers/friendli/models/zai-org/GLM-5.3-Flash.toml:11` - **Check:** Provider modality overrides must reflect what this host actually serves, not only the upstream lab. **Why:** Patch 2 cited Friendli `GET /serverless/v1/models` (2026-08-27) reporting `input_modalities: ["text"]` for `zai-org/GLM-5.3-Flash`, then patch 3 set `input = ["text", "image"]` with only a future-tense claim that Friendli “will serve” image input and no Friendli-side confirmation. That can mislabel the host as vision-capable when the catalog API said text-only. **Action:** Verify Friendli’s live modalities for this model ID. If the API still reports text-only, set `input = ["text"]` (and `attachment = false` if attachments are not served). If image is actually supported, keep the override and add a leading top-of-file comment citing the Friendli source that confirms image input (not only the lab checkpoint).
- **[low] [possible mistake]** `providers/friendli/models/zai-org/GLM-5.3-Flash.toml:14` - **Check:** Material cost changes should cite a direct provider pricing source. **Why:** Costs (`0.15` / `0.5` / `0.03`) match common third-party list prices but the PR body does not point to Friendli pricing or docs for this model, so host-specific pricing cannot be reviewed from the submission alone. **Action:** Add a Friendli pricing/docs citation (PR body and/or leading TOML comment) that maps to these USD/MTok values, or confirm they are intentional list prices from a named Friendli source. |
Contributor
Action items
|
- Confirmed input_modalities=[text,image,video] against live GET /serverless/v1/models — resolves the bot's modality-churn complaint with real evidence instead of another guess. - Added budget_tokens (min=-1, max=1_048_576) matching the live reasoning_options and https://friendli.ai/docs/openapi/model-apis/chat-completions#body-reasoning-budget-one-of-0. - Added [limit] override (context=1_048_576, output=1_048_576): live max_completion_tokens/context_length exceed the lab file's rounded 1_000_000. - Leading comment now cites the live API response for cost/modalities/ reasoning_options, resolving the bot's pricing-citation complaint.
Contributor
Author
|
Pushed
|
Contributor
|
No actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Friendli as a provider host for zai-org/GLM-5.3-Flash (
base_model = zhipuai/glm-5.3-flash, override-only).available at https://api.friendli.ai/serverless/v1/models
Reasoning
reasoning_effortvalueslow/high/maxper chat_template.jinja:Reasoning is always enabled (no toggle) — unrecognized/omitted values fall back to
max.Cost (USD/MTok)
Checklist
base_modelreasoning = true⇒reasoning_optionssetbun validatepasses