fix(macOS): handle Accessibility Keyboard shortcuts - #44
Open
davutac wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for tracing this to the event-tap boundary. I incorporated the annotated-session tap change in #45 and shipped it in Hex 2.1.7, alongside a fix for side-specific modifier matching. I kept the Activity logging additions out of this release. Could you update through Check for Updates and confirm Accessibility Keyboard hold/release and modifier-plus-key shortcuts work? The Rust suite and native synthetic-event routing checks pass, but I haven't verified the actual Accessibility Keyboard interaction locally. |
Author
|
Thank you. I can confirm this works now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Accessibility Keyboard injects key events after the HID event tap HEX previously used. Physical keyboards worked, but the same shortcut sent by Accessibility Keyboard never reached the listener.
Moving the tap fixes that. The new Activity entries make future shortcut problems easier to diagnose.
Testing
cargo test --bin voice-control suppression::tests -- --nocapture(30 passed)cargo test --bin voice-control events::tests -- --nocapture(6 passed)cargo test --bin voice-control app_window::tests::activity_summarizes_configured_shortcut_actions -- --exact --nocapture(1 passed)cargo fmt --checkgit diff --check