Skip to content

build: update all non-major dependencies - #3985

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-3970
Sep 18, 2026
Merged

alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-3970

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

See associated pull request for more information.

Closes #3970 as a pr takeover

See associated pull request for more information.

Closes angular#3970 as a pr takeover
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2026
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various dependencies and tool versions across the repository, including upgrading pnpm to 11.27.0 and @types/node to 24.13.5. Feedback on these changes highlights two main issues: first, targeting node24 in the esbuild configuration for Firebase Functions is premature as the runtime only supports up to Node 22, which could cause runtime crashes; second, the root pnpm-lock.yaml needs to be regenerated by running pnpm install to reflect the updated dependencies and prevent CI sync issues.

Comment thread apps/functions/BUILD.bazel
Comment thread package.json

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4
alan-agius4 merged commit 20b69d3 into angular:main Sep 18, 2026
16 of 17 checks passed
@alan-agius4

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the pr-takeover-3970 branch September 18, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants