feat(github-actions): remove preview label for non-googlers in pack-and-upload-artifact#3718
Open
josephperrott wants to merge 3 commits into
Open
feat(github-actions): remove preview label for non-googlers in pack-and-upload-artifact#3718josephperrott wants to merge 3 commits into
josephperrott wants to merge 3 commits into
Conversation
…nd-upload-artifact
There was a problem hiding this comment.
Code Review
This pull request introduces a new GitHub Action step to automatically remove the preview trigger label if the PR author is not a member of the googlers organization. The feedback highlights a critical authentication issue in the composite action due to unmapped inputs, and suggests optimizing the workflow by setting and checking a should-preview output to skip subsequent steps when appropriate. Additionally, improvements were suggested to handle potentially null PR authors, ensure robust token revocation in the finally block, and remove a redundant global cache.
AndrewKushnir
approved these changes
Jun 1, 2026
alan-agius4
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the automatic removal of the triggering preview label (e.g. `action: preview`) from `upload-artifacts-to-firebase` into the `pack-and-upload-artifact` action.
Key Changes: