Skip to content

build: mark rules_angular and rules_sass as dev dependencies#3599

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:dev-sep
Apr 10, 2026
Merged

build: mark rules_angular and rules_sass as dev dependencies#3599
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:dev-sep

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

rules_angular and rules_sass are only needed for development and testing, and should not be propagated to downstream consumers.

rules_angular and rules_sass are only needed for development and testing, and should not be propagated to downstream consumers.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 10, 2026
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 10, 2026
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 merged commit 583cd52 into angular:main Apr 10, 2026
13 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the dev-sep branch April 10, 2026 16:33
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors Bazel dependencies by marking rules_sass and rules_angular as development dependencies in the root MODULE.bazel file. It also removes redundant dev dependencies and local path overrides for these rules across several sub-modules, including rules_angular, rules_browsers, and rules_sass. Additionally, the lockfiles have been updated to reflect these changes and include a downgrade of the jq.bzl module in certain sub-packages. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants