fix(bazel/rules_angular): ensure correct typescript version is utilized in persistent worker runfiles#3598
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Angular module extension to handle root module setup and uses labels for compiler and TypeScript dependencies. It also improves runfile collection for symlinked packages and introduces a BazelSafeFilesystem for worker execution. Review feedback suggests addressing potential path resolution issues in the sandbox environment, ensuring compatibility with older Node.js versions by avoiding import.meta.filename, and adding provider validation for the symlink rule.
alan-agius4
force-pushed
the
worker-ts-version-resolve
branch
2 times, most recently
from
2f6bcec to
cc8d72a
Compare
…ed in persistent worker runfiles Updates the symlink_package rule to correctly propagate transitive source files, including standard library definitions, into the generated Bzlmod runfiles layout. Additionally, integrates the BazelSafeFilesystem instance within the persistent compiler worker to reliably resolve and load the workspace-provided TS toolchain at execution time.
alan-agius4
force-pushed
the
worker-ts-version-resolve
branch
from
cc8d72a to
6cd21db
Compare
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Just one thing I want to make sure we think through, but happy with whatever decision you make on it.
| angular_compiler_cli = attr.angular_compiler_cli, | ||
| typescript = attr.typescript, | ||
| ) | ||
| if attr.name not in generated: |
There was a problem hiding this comment.
I understand we have control here so we can manage it, but does this mean that we we will just silently "fail" if someone tries to use the same name twice?
If dev-infra creates "dependency_rules_angular_configurable_deps" and then in framework we also create "rules_angular_configurable_deps", the dev-infra one would be encountered first and the framework one would get skipped? Would it make more sense to ensure that the same name is not generated twice?
There was a problem hiding this comment.
Yes let me add an error message.
… utilized in persistent worker runfiles
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
Updates the symlink_package rule to correctly propagate transitive source files, including standard library definitions, into the generated Bzlmod runfiles layout. Additionally, integrates the BazelSafeFilesystem instance within the persistent compiler worker to reliably resolve and load the workspace-provided TS toolchain at execution time.