Skip to content

fix(bazel/rules_angular): update worker to use user-configured TypeScript instead of npm version #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Apr 9, 2026
Merged

fix(bazel/rules_angular): update worker to use user-configured TypeScript instead of npm version #3597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/rules/rules_angular/src/worker/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ ts_project(
# NOTE: The Angular compiler in this target is not affecting any compilation
# output, but it's still necessary for some foundational utils like virtual FS.
"//:node_modules/@angular/compiler-cli", # compiler from npm.
"//:node_modules/typescript", # typescript from npm.
":node_modules/typescript", # user-configured typescript. Ensure that the users TypeScript version is always used for the compilation.
Copy link
Copy Markdown
Member

@josephperrott josephperrott Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was previously using the version from npm because we can cause mismatches between the expected typescript types for the local envinronment (the users TS version) and the version that @angular/compiler-cli expects from npm.

Is that not a concern? Or I am misunderstanding?

Copy link
Copy Markdown
Contributor Author

@alan-agius4 alan-agius4 Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with that approach is that any usage of ts_project will use the built-in version of the TypeScript instead of what is supplied by the users.

In the case of having mismatches, I think we need to come up with a better solution or use an @angular/compiler-cli version that supports the TypeScript versions that are used in both main and patch.

One other alternative would be not using the the @angular/compiler-cli FS for plain TS compilations but that is a larger task.

Copy link
Copy Markdown
Member

@josephperrott josephperrott Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, If we are okay with moving the "error point" to the angular compiler-cli version like this, thats fine with me.

],
)

Expand Down
Loading