Skip to content

fix(@angular/cli): update MCP devserver tool names to conform to spec regex#33629

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:fix/mcp-tool-names
Jul 23, 2026
Merged

fix(@angular/cli): update MCP devserver tool names to conform to spec regex#33629
clydin merged 1 commit into
angular:mainfrom
clydin:fix/mcp-tool-names

Conversation

@clydin

@clydin clydin commented Jul 23, 2026

Copy link
Copy Markdown
Member

MCP tool names must adhere to the regular expression ^[a-zA-Z0-9_-]+$. This commit updates devserver.start, devserver.stop, and devserver.wait_for_build to use underscores (devserver_start, devserver_stop, devserver_wait_for_build) and updates all corresponding tool references and documentation across the MCP command package.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Jul 23, 2026
@clydin clydin linked an issue Jul 23, 2026 that may be closed by this pull request
2 tasks
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces dots with underscores in MCP tool names (e.g., renaming devserver.start to devserver_start) and updates all corresponding references in descriptions and error messages. A review comment suggests fixing a minor grammatical repetition ("that that app") in the description of the devserver_start tool.

Comment thread packages/angular/cli/src/commands/mcp/tools/devserver/devserver-start.ts Outdated
@clydin
clydin force-pushed the fix/mcp-tool-names branch from 42b57fe to 6ddd281 Compare July 23, 2026 11:52
@clydin clydin removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 23, 2026
… regex

MCP tool names must adhere to the regular expression ^[a-zA-Z0-9_-]+$. This commit updates devserver.start, devserver.stop, and devserver.wait_for_build to use underscores (devserver_start, devserver_stop, devserver_wait_for_build) and updates all corresponding tool references and documentation across the MCP command package.
@clydin
clydin force-pushed the fix/mcp-tool-names branch from 6ddd281 to 5649c66 Compare July 23, 2026 12:01
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Jul 23, 2026
@clydin
clydin merged commit e12e002 into angular:main Jul 23, 2026
67 of 68 checks passed
@clydin

clydin commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the fix/mcp-tool-names branch July 23, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

angular-cli troublesome tooling name causes Claude desktop to fail

2 participants