Skip to content

Feature: admin module#1318

Merged
Awk34 merged 4 commits into
angular-fullstack:canaryfrom
kingcody:feature/admin-module
Oct 6, 2015
Merged

Feature: admin module#1318
Awk34 merged 4 commits into
angular-fullstack:canaryfrom
kingcody:feature/admin-module

Conversation

@kingcody

Copy link
Copy Markdown
Member

Changes:

  • move admin components to admin module
  • use controllerAs syntax for AdminController
  • refactor AdminController, remove unneeded and verbose code
  • use class for AdminController
  • fix and update karma.conf.js (file order, conditionally exclude jade preprocessor)

@kingcody kingcody force-pushed the feature/admin-module branch from 8dc1c1b to f95ace1 Compare September 17, 2015 00:46
@kingcody

Copy link
Copy Markdown
Member Author

Partially closes #476. I think we should separate the User resource into a user module. Then admin won't have to depend on auth, which should make it very easy to reuse.

@kingcody kingcody added this to the 3.0.0 milestone Sep 17, 2015
@kingcody

Copy link
Copy Markdown
Member Author

@Awk34 I'll need to rebase this after we merge #1312

@kingcody kingcody force-pushed the feature/admin-module branch from f95ace1 to 618461f Compare September 17, 2015 05:46
Awk34 added a commit that referenced this pull request Oct 6, 2015
@Awk34 Awk34 merged commit 789c64c into angular-fullstack:canary Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants