Skip to content

chore: update to Angular 21.2#299

Open
michael-small wants to merge 10 commits intomainfrom
chore-21.2
Open

chore: update to Angular 21.2#299
michael-small wants to merge 10 commits intomainfrom
chore-21.2

Conversation

@michael-small
Copy link
Copy Markdown
Collaborator

No description provided.

@michael-small michael-small marked this pull request as ready for review April 21, 2026 14:34
@michael-small michael-small self-assigned this Apr 21, 2026
Copy link
Copy Markdown
Collaborator

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michael, I think that this is not just the update but includes also the snapshot?

Would it be possible only to touch those files that are really necessary for the upgrade to 21.2?

@michael-small
Copy link
Copy Markdown
Collaborator Author

Ah, I forgot that I had done some preliminary stuff with the snapshots. The implementation of withResource did have to be changed a bit for the new shape of resources including the snapshot property so it could continue working. But these changes went beyond that like you saw.

I think I can more cleanly just re-do this update fresh on a different branch.

Should I expose the snapshot property to be exposed to the store for a resource for parity with 21.2 resources now all having a snapshot property?

@rainerhahnekamp
Copy link
Copy Markdown
Collaborator

Should I expose the snapshot property to the store for a resource for parity with 21.2 resources, now all having a snapshot property?

So I'd say that all those demo files that got changed shouldn't be in the PR (unless there is a real reason for it).

Since 21.2 has the snapshot property, there is a chance that we are running into a compilation error with withResource. So if the compilation/build fails, you would have to update withResource as well. If it does not fail, I think, adding snapshot to withResource could be even a separate PR.

@msmallest
Copy link
Copy Markdown
Contributor

@rainerhahnekamp before I close this on my main account:

Question 1: snapshot property, and where to add it

If it does not fail, I think, adding snapshot to withResource could be even a separate PR.

Since the update did not fail, I am wondering: should the snapshot property be exposed by

  • It's own PR, right on top of the 21.2 bump that was just merged?
  • OR At the same time as the PR to widen withResource to be able to take Resource?

Question 2: httpResource exposed properties, when?

We mentioned at some point that exposing some httpResource specific properties should be done.

Should that be done

  • In it's own PR
  • OR At the same time as the PR to widen withResource to be able to take Resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants