Add delegation_type support to OpenID4VP presentation matcher - #215
Open
danieljkim1 wants to merge 1 commit into
Open
Add delegation_type support to OpenID4VP presentation matcher#215danieljkim1 wants to merge 1 commit into
danieljkim1 wants to merge 1 commit into
Conversation
- Add SetDelegationTypeForEntryInSet to bindings.rs and CredmanApi trait - Add delegation_type field to RegistryCredential and MatchedCredential in openid4vp_models.rs - Propagate candidate.delegation_type through dcql.rs to reporter.rs for presentation entry sets - Update test utilities and mock implementations for 11-parameter add_entry_to_set signature TAG=agy CONV=0b44330c-f824-447d-83ba-c4685a5977a5
danieljkim1
force-pushed
the
wasm-pr-delegation
branch
from
July 29, 2026 08:17
97c6ecf to
bcdb50f
Compare
danieljkim1
changed the title
|
Btw, not ready for review yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for provider
delegation_typein the OpenID4VP presentation matcher (matcher-rs).Summary of Changes:
bindings.rs: DeclaredSetDelegationTypeForEntryInSetFFI function imported from the Android Credential Manager host runtime.credman.rs: Addeddelegation_type: i32parameter toadd_entry_to_setand exposedset_delegation_type_for_entry_in_setinCredmanApitrait.openid4vp_models.rs: Addedpub delegation_type: i32toRegistryCredentialandMatchedCredential.dcql.rs&reporter.rs: Propagatedcandidate.delegation_typethrough DCQL matching toreporter.rswhen populating presentationentrySetitems viacredman.add_entry_to_set(...).TAG=agy
CONV=0b44330c-f824-447d-83ba-c4685a5977a5