Fix the memory leak in the sample app#199
Merged
Merged
Conversation
Replace the activity context to application context to prevent memory leak in Activity reconstruction case.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| class JsonProvider(private val context: Context) { | ||
| class JsonProvider(context: Context) { | ||
|
|
||
| val context = context.applicationContext |
There was a problem hiding this comment.
Collaborator
|
HI Thanks for raising this. Can you check the sample if it is reproducible in that point your changes here then : https://github.com/android/identity-samples/tree/main/Shrine as we might be deprecating or shifting compose sample to main soon. |
cy245
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the activity context to application context to prevent memory leak in Activity reconstruction case.