Skip to content

Add search messages and schema updates#26

Open
corinac123 wants to merge 17 commits into
android:mainfrom
corinac123:update-schema
Open

Add search messages and schema updates#26
corinac123 wants to merge 17 commits into
android:mainfrom
corinac123:update-schema

Conversation

@corinac123

Copy link
Copy Markdown
Contributor

Added app function to search messages.
Update schema with some nit renames.

* Add an endpoint for Bob

* Repository returns all recipients with same name

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the chat application's app functions by renaming the message sending function to sendMessage (returning a simple string), updating ContactSearchResult with more descriptive fields, and introducing a new searchMessages function along with its corresponding data models and tests. The review feedback suggests validating against empty queries in searchMessages to prevent performance and privacy issues, querying messages concurrently rather than sequentially, and optimizing searchRecipients by applying take(maxCount) before mapping the elements when the query is blank.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/appfunctions/AppFunctions.kt Outdated
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/appfunctions/AppFunctions.kt Outdated
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/data/RecipientsRepository.kt Outdated
Comment thread ChatApp/app/src/main/kotlin/com/example/chatapp/data/RecipientsRepository.kt Outdated
@corinac123
corinac123 requested a review from keyboardsurfer July 9, 2026 12:50
@keyboardsurfer

Copy link
Copy Markdown
Member

We have made some updates to the repository and build files. Please resolve the merge conflicts so we can get this onto main.

@corinac123
corinac123 requested a review from a team as a code owner July 21, 2026 15:41
@corinac123

Copy link
Copy Markdown
Contributor Author

Conflicts merged, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants