You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could we use str::lines() at the affected assertions instead of normalizing the whole rendered string? It handles both LF and CRLF. For the source assertion, we could use rendered.lines().any(|line| line == expected), with expected = format!("Source: {source}"). For the multiline renderer assertions, collecting the lines and checking adjacent windows() would let us keep asserting the blank lines needed between HTML and Markdown without depending on line endings. No extra dependency or helper needed.
Implemented the requested newline-agnostic assertions in 058d671: source checks now use str::lines(), and the renderer tests collect lines and use adjacent windows() for the required blank-line structure. Validation: git diff --check, cargo fmt --check for both crates, targeted pr-check test (1 passed), and render deprecated tests (3 passed). CI checks are pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation