feat: add testID prop for E2E testing#46
Open
cyril36 wants to merge 1 commit into
Open
Conversation
Adds an optional `testID` prop to GooglePlacesTextInput that is propagated as a suffix to all internal components (container, input wrapper, text input, clear button, loading indicator, suggestions container, suggestions list, and individual suggestion items), enabling reliable selection in E2E tests such as Maestro and Detox. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testIDprop toGooglePlacesTextInputTextInput, clear button, loading indicator, suggestions container, suggestions list, and individual suggestion items)When
testID="address"is passed, internal elements becometextinput-address,suggestion-touchableopacity-0-address,clear-button-address, etc. WhentestIDis omitted, the suffix is empty, preserving the existing behaviour.Test plan
testIDand confirm no behavioural changetestID="foo"and verify each internal element exposes the expected suffixed testID🤖 Generated with Claude Code