Remove Wants= from update-motd.service as it was unexpectedly re-executing userdata script. - #5
Open
joeysk2012 wants to merge 1 commit into
Open
Remove Wants= from update-motd.service as it was unexpectedly re-executing userdata script.#5joeysk2012 wants to merge 1 commit into
joeysk2012 wants to merge 1 commit into
Conversation
…cuting userdata scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Wants=network-online.target cloud-final.serviceas it will re-trigger the cloud-final.service when the user-data script exits on a failure. This causes unexpected behavior as the userdata script is unknowingly triggered when the user does not expect it to.Refactor the spec file to download the tar file from a release and then extract the 3 needed files rather than have to download and extract manually into the packaging repo. The source tar usually belongs in the Source section of the spec file. This way we can make a quick 'author update' every time update-motd version is released.