Skip to content

[07] [M0.6] Establish the represented-to-live bridge convention#87

Merged
alseif0x merged 4 commits into
3.4.3from
19-07-m06-establish-the-represented-live-bridge-convention
Jul 12, 2026
Merged

[07] [M0.6] Establish the represented-to-live bridge convention#87
alseif0x merged 4 commits into
3.4.3from
19-07-m06-establish-the-represented-live-bridge-convention

Conversation

@alseif0x

@alseif0x alseif0x commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Closes #19

Summary

  • Establishes the typed represented-to-live bridge convention using CMSG_STAND_STATE_CHANGE as the converted live example.
  • Mutates canonical Unit stand state and applies the C++ Standing aura/channel interruption semantics from effective DB2, hotfix, and server-side spell metadata.
  • Preserves realm/instance packet routing and canonical map update ownership.
  • Adds the stand-state wow-test-bot flow, connection-aware capture-diff support, and a committed clean C++/Rust fixture.

Validation

  • ./tools/pr-preflight.sh full origin/3.4.3
  • 2,718 wow-world library tests passed; all other focused CI suites passed.
  • stand bot passed requested/confirmed state [1] against the running server.
  • strict capture-diff: CLEAN, 4 matched packets, with no value, routing, missing, or extra divergences.
  • local Codex review: CLEAN on 5856119.

Remaining represented-partial boundaries

  • Full Spell::cancel target/packet/remote-effect cleanup and cross-Unit aura applications.
  • Original cast-difficulty retention on older thin spell records.
  • Real canonical per-viewer SendObjectUpdates fanout beyond the captured seam.
  • Other stand-state callers and wider SpellInfo/interrupt/localization coverage.

@alseif0x

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: a549f357c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

alseif0x commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

QA validation checklist:

  • This PR is mostly runtime plumbing/convention, so validate it as a client smoke test.
  • Log in, enter world, move between nearby areas, target creatures/NPCs, and perform a basic attack/cast.
  • Logout to character select and reconnect with the same client session; visible creatures/NPCs should reload normally.
  • Watch for server crashes, missing nearby spawns, or obvious duplicate/stale object behavior.

If this stays green in checks, it can remain pending user QA; no special gameplay flow is expected beyond regression coverage.

@alseif0x alseif0x force-pushed the 19-07-m06-establish-the-represented-live-bridge-convention branch from a549f35 to 5856119 Compare July 12, 2026 22:34
@alseif0x alseif0x changed the title [07] Establish represented-to-live bridge convention [07] [M0.6] Establish the represented-to-live bridge convention Jul 12, 2026
@alseif0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5856119e87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alseif0x alseif0x merged commit 3cd08f1 into 3.4.3 Jul 12, 2026
7 checks passed
@alseif0x alseif0x deleted the 19-07-m06-establish-the-represented-live-bridge-convention branch July 12, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[07] [M0.6] Establish the represented->live bridge convention

1 participant