Skip to content

TCS-12: Shim eslint-plugin-react for ESLint v10, drop react-hooks shim as it's not needed anymore #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nettree merged 1 commit into from
Aug 7, 2026
Merged

TCS-12: Shim eslint-plugin-react for ESLint v10, drop react-hooks shim as it's not needed anymore #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,18 @@ const base = [

const react = [
...base,
reactPlugin.configs.flat.recommended,
jsxA11yPlugin.flatConfigs.recommended,
// `react-hooks` plugin doesn't support "flat configs" yet so it has to be wrapped in the compatibility layer
{
plugins: { 'react-hooks': fixupPluginRules(hooksPlugin) },
rules: hooksPlugin.configs.recommended.rules,
// `eslint-plugin-react` (7.37.5, the latest release) calls the removed
// `context.getFilename()` API when resolving the React version, which throws
// "Error while loading rule 'react/display-name'" on ESLint 10 whenever
// `settings.react.version` is 'detect'. Wrapping the plugin with fixupPluginRules
// restores the legacy context methods, so version detection keeps working.
// Replace this object with `reactPlugin.configs.flat.recommended` once the plugin supports ESLint 10.
...reactPlugin.configs.flat.recommended,
plugins: { react: fixupPluginRules(reactPlugin) },
},
jsxA11yPlugin.flatConfigs.recommended,
hooksPlugin.configs.flat.recommended,
{
settings: { react: { version: 'detect' } },
rules: {
Expand Down
Loading