feat(fts): add stemmer token filter based on Snowball 3.1.1#513
Open
egolearner wants to merge 4 commits into
Open
feat(fts): add stemmer token filter based on Snowball 3.1.1#513egolearner wants to merge 4 commits into
egolearner wants to merge 4 commits into
Conversation
egolearner
force-pushed
the
feat/fts-stemmer-token-filter
branch
from
9ddb69a to
dd53084
Compare
egolearner
force-pushed
the
feat/fts-stemmer-token-filter
branch
from
dd53084 to
11961a4
Compare
| filter_name.c_str()); | ||
| return nullptr; | ||
| } | ||
| if (!filter->init(extra_json)) { |
Collaborator
There was a problem hiding this comment.
头文件里以及py docstring需要注明stemmer extra json的使用说明吧？另外也需要注明stemmer filter
| } | ||
| auto *test_stemmer = sb_stemmer_new(language_.c_str(), nullptr); | ||
| if (!test_stemmer) { | ||
| LOG_ERROR("[StemmerTokenFilter] failed to create stemmer for language: %s", |
Collaborator
There was a problem hiding this comment.
报错位置有点深，可以放在schema validate？
| TokenFilterPtr TokenizerFactory::create_filter(const std::string &filter_name) { | ||
| if (filter_name == "lowercase") { | ||
| return std::make_shared<LowercaseTokenFilter>(); | ||
| } else if (filter_name == "stemmer") { |
Collaborator
There was a problem hiding this comment.
es如果设置stemmer，内部默认是porter，和zvec的行为(snowball+english)不一致，这个需要注释下以及在文档透出
参考：https://www.elastic.co/docs/reference/text-analysis/analysis-stemmer-tokenfilter
Implement a stemmer token filter for FTS that reduces words to their root form using the Snowball stemming library. Supports 34+ languages configurable via stemmer_lang in extra_params (defaults to english). Changes: - Integrate Snowball 3.1.1 as a thirdparty static library - Add StemmerTokenFilter with thread_local stemmer cache (lock-free) - Register 'stemmer' filter in TokenizerFactory - Add unit tests and FtsColumnIndexer end-to-end tests
egolearner
force-pushed
the
feat/fts-stemmer-token-filter
branch
from
c5a25cc to
151a562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a stemmer token filter for FTS that reduces words to their root form using the Snowball stemming library. Supports 34+ languages configurable via stemmer_lang in extra_params (defaults to english).
Changes: