ui: format Audio.duration as h:mm:ss instead of raw seconds#4414
Open
c-tonneslan wants to merge 15 commits into
Open
ui: format Audio.duration as h:mm:ss instead of raw seconds#4414c-tonneslan wants to merge 15 commits into
c-tonneslan wants to merge 15 commits into
Conversation
…e-main fix: docker-compose image tax syntax broken after merge
ingest-file uses the Tags functionality from servicelayer to cache certain document types during ingest to speed up its operation. Normally the settings file defaults to trying the ALEPH_DATABASE_URI followed by the FTM_STORE_URI, which in most cases should be set to non-default values. But if one were to just follow our prod environment docs blindly and not uncomment these two settings then the TAGS_DATABASE_URI would be unset, causing servicelayer to pick the default (sqlite:///) which breaks now that we have multiple threads writing to the tags database. This change documents how this setting works and encourages one to set it if the above two settings are left to defaults. Relates to alephdata#4002, alephdata#3816
…tags-db bugfix: Point out use of Tags db and how it works
Release/4.1.1
Release/4.1.2 into main
* Bump default ingest-file version to 4.1.2 * Bump version: 4.1.2 → 4.1.3-rc1 * Fix ingest-file version (because bump2version confused it with the Aleph version) * Bump version: 4.1.3-rc1 → 4.1.3-rc2 * Bump version: 4.1.3-rc2 → 4.1.3
Release/4.1.4
Release/4.1.5
Release/4.1.6
The metadata panel displayed audio file duration as a bare seconds value with three decimals (e.g. '212.345'). Hard to read; not obvious it's a duration at all without the unit. Added a Duration component (mirroring FileSize) that renders the property as h:mm:ss when there's at least one full hour, mm:ss otherwise. Wired it into PropertyValue alongside the existing fileSize special case. Closes alephdata#3274. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata panel displays audio file duration as a bare seconds value with three decimals (e.g. `212.345`). It's hard to read and not obvious it's a duration at all without the unit.
Added a `Duration` component (mirroring `FileSize`) that renders the property as `h:mm:ss` when there's at least one full hour, `mm:ss` otherwise. Wired it into `PropertyValue` alongside the existing `fileSize` special case.
closes #3274