safely initialize src_languages and dst_languages - #3
Open
olfMombach wants to merge 2 commits into
Open
Conversation
olfMombach
requested review from
maxmil,
stevenxxiu and
tomsquest
and
a lite review from Copilot
August 27, 2026 12:41
There was a problem hiding this comment.
Pull request overview
This PR addresses plugin startup/runtime failures when translator language discovery fails, by ensuring src_languages and dst_languages are initialized before attempting to load supported languages (Issue #1).
Changes:
- Initialize
src_languages/dst_languagesbeforets.get_languages(...)so later query handling doesn’t hit missing-attribute errors.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1