Skip to content

fix(audit): serialize provider audited attributes in queries#2070

Open
chalabi2 wants to merge 1 commit into
mainfrom
fix/query-provider-audit-attributes
Open

fix(audit): serialize provider audited attributes in queries#2070
chalabi2 wants to merge 1 commit into
mainfrom
fix/query-provider-audit-attributes

Conversation

@chalabi2
Copy link
Copy Markdown
Contributor

@chalabi2 chalabi2 commented Jun 3, 2026

Description

Closes: akash-network/support#606

Fixes malformed provider audit attribute query responses by decoding stored
audit values as AuditedAttributesStore and reconstructing owner and
auditor from the store key.

The current query implementation decodes audit store values as
AuditedProvider. Since AuditedAttributesStore.attributes and
AuditedProvider.owner are both protobuf field 1, all-provider and
auditor-filtered queries return attribute bytes in the owner field while
auditor and attributes are empty.

Critical files to review:

  • x/audit/keeper/grpc_query.go
  • x/audit/keeper/grpc_query_test.go
  • x/audit/keeper/keeper.go

Validation:

  • GOWORK=off go test ./x/audit/keeper -count=1
  • GOWORK=off go test ./x/audit/... -count=1

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
    • Not applicable: this is not an API or client breaking change.
  • targeted the correct branch (see PR Targeting)
    • Targeting main for normal review and merge.
  • provided a link to the relevant issue or specification
    • No GitHub issue exists; this was reported in Slack on 2026-06-03.
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
    • Not applicable: narrow query serialization fix for an RC branch.
  • included comments for documenting Go code
    • Not applicable: no exported API or new Go doc surface.
  • updated the relevant documentation or specification
    • Not applicable: no documentation/spec change.
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed
    • Pending PR CI.

@chalabi2 chalabi2 requested a review from a team as a code owner June 3, 2026 21:28
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7d83a9d8-5546-45a4-9a2f-314ca5cece9a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/query-provider-audit-attributes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix malformed provider audit attributes query responses

2 participants