fix: GzipParser passes through non-gzipped data instead of raising BadGzipFile#1072
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
fix: GzipParser passes through non-gzipped data instead of raising BadGzipFile#1072devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…dGzipFile Co-Authored-By: lucas.leadbetter@airbyte.io <5595530+lleadbet@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1783966700-gzip-parser-passthrough#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1783966700-gzip-parser-passthroughPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GzipParser.parsedocumented that "if the data is not gzipped, pass the data to the inner parser as is", but never implemented it — it unconditionally wrapped the stream ingzip.GzipFile, so any layer that isn't actually gzip crashes withBadGzipFile: Not a gzipped file (...).This bites declarative connectors that stack decoders, because
create_gzip_decoderbuilds a header-selected decoder whose fallback strips exactly one gzip layer:When a response intermittently arrives with fewer gzip layers than configured (or as an unexpected format, e.g. a zip archive with magic
b'PK'), the rigid parser raisesBadGzipFileand the stream fails. This surfaced as an intermittentBadGzipFile: Not a gzipped file (b'PK')on a custom App Store Connect connector'ssubscription_event_reportstream.Fix: peek the leading bytes (via
io.BufferedReader, which does not consume the stream and works uniformly over urllib3 raw responses,GzipFile, andBytesIO) and only gzip-decompress when the gzip magic number is present; otherwise hand the stream straight to the inner parser.This makes nested/fallback gzip decoding tolerant of 0, 1, or N gzip layers and is fully backward-compatible when data is gzipped. Note: a genuinely zip-compressed (
b'PK') payload still needs aZipfileDecoderfor that layer — this change stops the hard crash but does not unzip.Tests
test_composite_decoder.py: singleGzipParserpassthrough on uncompressed data; nestedGzipParser(GzipParser(CsvParser))handling both one and two gzip layers; header-based fallback to aGzipParseron a non-gzipped response.Link to Devin session: https://app.devin.ai/sessions/862184b2ca174e4483b2cc1b5264e978