feat(sqlalchemy): validate UUID input fields#1168
Draft
aiolibsbot wants to merge 1 commit into
Draft
Conversation
UUID columns rendered as TextInput accepted any string on the client. Emit a canonical-form regex validator so malformed UUIDs are caught in the create/edit forms before submission. Completes the 'validators' TODO on the sa.Uuid mapping (part of aio-libs#666). The frontend already deserializes regexp validator state, so no admin-js change is needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
+ Coverage 95.56% 95.65% +0.08%
==========================================
Files 21 21
Lines 2954 2966 +12
Branches 193 201 +8
==========================================
+ Hits 2823 2837 +14
+ Misses 105 103 -2
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: UUID columns now emit a regex validator so admin create/edit forms reject malformed UUIDs client-side.
Why:
sa.Uuidmapped to a plainTextInputwith no validation (the# TODO: validatorson the mapping). Any string was accepted in the form and only rejected server-side by Pydantic — a worse UX than the surrounding validated inputs. Part of #666 (TODO cleanup).How: Added a canonical-form UUID pattern (
8-4-4-4-12hex, matchingstr(uuid.UUID(...))) and appended aregexvalidator forsa.Uuidcolumns in_get_validators. The frontend already deserializesregexpvalidator state into aRegExp, so no admin-js change is needed. Server-side Pydantic validation is unchanged and remains authoritative.Testing: New
test_uuid_validatorasserts the emitted validator. Full suite: 98 passed, 1 xfailed; the lonetest_admin_viewfailure is pre-existing (#934) and unrelated.Quality Report
Changes: 2 files changed, 22 insertions(+), 1 deletion(-)
Code scan: clean
Tests: failed (command not found)
Branch hygiene: clean
Generated by Kōan