Skip to content

chore(ci): update secret env references to variable env references #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mk0x9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ci): update secret env references to variable env references #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/_report-to-ketryx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ on:
required: true
type: string
secrets:
KETRYX_PROJECT:
description: 'Ketryx project ID'
required: true
KETRYX_API_KEY:
description: 'Ketryx API key'
required: true
Expand All @@ -36,7 +33,7 @@ jobs:
- name: Report to Ketryx
uses: Ketryx/ketryx-github-action@v1.4.0
with:
project: ${{ secrets.KETRYX_PROJECT }}
project: ${{ vars.KETRYX_PROJECT }}
api-key: ${{ secrets.KETRYX_API_KEY }}
build-name: ${{ inputs.build-name }}
test-junit-path: test-results/**/*.xml
5 changes: 2 additions & 3 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ jobs:
run: npm run test:cli:e2e
env:
E2E_REFRESH_TOKEN: ${{ secrets.E2E_REFRESH_TOKEN }}
E2E_TEST_ENVIRONMENT: ${{ secrets.E2E_TEST_ENVIRONMENT }}
E2E_ADMIN_USER_EMAIL: ${{ secrets.E2E_ADMIN_USER_EMAIL }}
E2E_TEST_ENVIRONMENT: ${{ vars.E2E_TEST_ENVIRONMENT }}
E2E_ADMIN_USER_EMAIL: ${{ vars.E2E_ADMIN_USER_EMAIL }}
E2E_ADMIN_USER_PASSWORD: ${{ secrets.E2E_ADMIN_USER_PASSWORD }}

- name: Upload SDK test results
Expand Down Expand Up @@ -140,7 +140,6 @@ jobs:
with:
build-name: 'pre-release'
secrets:
KETRYX_PROJECT: KXPRJ7NZ5C47Q0Q84FTG9AZ2T17N8J2 # not a secret
KETRYX_API_KEY: ${{ secrets.KETRYX_API_KEY }}

release:
Expand Down
Loading