Skip to content

docs(specs): document scheduling support in application service spec#557

Merged
olivermeyer merged 1 commit into
mainfrom
docs/document-pr-479
Apr 23, 2026
Merged

docs(specs): document scheduling support in application service spec#557
olivermeyer merged 1 commit into
mainfrom
docs/document-pr-479

Conversation

@olivermeyer

@olivermeyer olivermeyer commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Why?
PR #479 added first-class scheduling support (due_date/deadline) to application run submission, but the SPEC-APPLICATION-SERVICE.md was not updated to reflect these changes.

How?
Expanded the application_run_submit signature with all current parameters including due_date and deadline and added the previously undocumented application_run_submit_from_metadata method.

Copilot AI review requested due to automatic review settings April 22, 2026 09:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the application service specification to reflect first-class scheduling support (due_date/deadline) and the current run submission API surface.

Changes:

  • Expanded application_run_submit signature and argument documentation to include scheduling and other current parameters.
  • Documented application_run_submit_from_metadata in the public API section.
  • Added scheduling date validation rules to the validation section.
Comments suppressed due to low confidence (1)

specifications/SPEC-APPLICATION-SERVICE.md:346

  • There’s no blank line between the end of application_run_submit_from_metadata and the next method definition inside the fenced Python example (pass is immediately followed by def application_run_download). Adding a blank line would keep the interface example consistently formatted and easier to read.
        pass
    def application_run_download(

Comment thread specifications/SPEC-APPLICATION-SERVICE.md
Comment thread specifications/SPEC-APPLICATION-SERVICE.md
Comment thread specifications/SPEC-APPLICATION-SERVICE.md
@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 7 files with indirect coverage changes

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@olivermeyer olivermeyer force-pushed the docs/document-pr-479 branch from cc8c1e3 to 9efac52 Compare April 23, 2026 06:55
@sonarqubecloud

Copy link
Copy Markdown

@olivermeyer olivermeyer merged commit 299f66b into main Apr 23, 2026
27 of 28 checks passed
@olivermeyer olivermeyer deleted the docs/document-pr-479 branch April 23, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants