Skip to content

test: increase run deadline #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olivermeyer merged 1 commit into from
Apr 17, 2026
Merged

test: increase run deadline #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/aignostics/application/cli_pipeline_validation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def test_cli_run_submit_succeeds_with_valid_pipeline_config(runner: CliRunner, t
HETA_APPLICATION_ID,
str(csv_path),
"--deadline",
(datetime.now(tz=UTC) + timedelta(seconds=5)).isoformat(),
(datetime.now(tz=UTC) + timedelta(seconds=60)).isoformat(),

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the run deadline is increased to 60 seconds, but this test now sets the deadline to 5 minutes. Please align the implementation with the PR description (e.g., use ~60 seconds) or update the PR description/title to match the 5-minute change.

Copilot uses AI. Check for mistakes.
"--gpu-type",
"L4",
"--gpu-provisioning-mode",
Expand Down Expand Up @@ -261,7 +261,7 @@ def test_cli_run_submit_succeeds_with_valid_a100_config(runner: CliRunner, tmp_p
HETA_APPLICATION_ID,
str(csv_path),
"--deadline",
(datetime.now(tz=UTC) + timedelta(seconds=5)).isoformat(),
(datetime.now(tz=UTC) + timedelta(seconds=60)).isoformat(),

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the run deadline is increased to 60 seconds, but this test now sets the deadline to 5 minutes. Please align the implementation with the PR description (e.g., use ~60 seconds) or update the PR description/title to match the 5-minute change.

Copilot uses AI. Check for mistakes.
"--gpu-type",
"A100",
"--gpu-provisioning-mode",
Expand Down
Loading