test: run heavy test on ubuntu-latest only#517
Conversation
olivermeyer
requested a review
from helmut-hoffer-von-ankershoffen
as a code owner
There was a problem hiding this comment.
Pull request overview
This PR reduces external platform load by ensuring a particularly heavy long-running E2E CLI test is only executed on the Linux x86_64 CI runner (intended to be ubuntu-latest) rather than across the full multi-OS runner matrix.
Changes:
- Add a
pytest.mark.skipifgate to prevent the heavy E2E test from running on macOS, Windows, and Linux ARM runners.
| @pytest.mark.skipif( | ||
| (platform.system() == "Linux" and platform.machine() in {"aarch64", "arm64"}) | ||
| or (platform.system() in {"Darwin", "Windows"}), | ||
| reason="Only hit on ubuntu-latest runner to avoid creating unnecessary load on the platform.", | ||
| ) |
There was a problem hiding this comment.
The skip condition is OS/arch-based (runs on any Linux x86_64), but the skip reason says it will run only on the ubuntu-latest runner. Consider either tightening the condition (e.g., also check GITHUB_ACTIONS/runner env) or rewording the reason to match the actual behavior (e.g., “run only on Linux x86_64 / GitHub Actions ubuntu-latest”).
olivermeyer
force-pushed
the
test/ubuntu-latest-runner
branch
from
4db56f6 to
f3f728f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. |
olivermeyer
force-pushed
the
test/ubuntu-latest-runner
branch
from
f3f728f to
9ef5953
Compare
olivermeyer
force-pushed
the
test/ubuntu-latest-runner
branch
from
9ef5953 to
214d4a9
Compare
|
Running
test_cli_run_submit_and_describe_and_cancel_and_download_and_deleteon all runners created unrealistic load on the platform. We will run it only on theubuntu-latestrunner instead.