test: increase run deadline#547
Conversation
olivermeyer
requested review from
a team and
helmut-hoffer-von-ankershoffen
as code owners
olivermeyer
force-pushed
the
test/increase-deadline
branch
from
dcc7276 to
aa13366
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize end-to-end CLI run submission tests by avoiding “deadline must not be in the past” validation failures during submission.
Changes:
- Increase the
--deadlineused in twoapplication run submitE2E tests (from+5sto+5m). - Update the NiceGUI dependency requirement to
>=3.10.0,<4and refreshuv.lock. - Adjust the notebook serving integration test to use
nicegui.testing.User’s async HTTP client.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/aignostics/application/cli_pipeline_validation_test.py |
Extends test run deadlines to reduce flakiness during run submission. |
tests/aignostics/notebook/service_test.py |
Switches notebook endpoint test to async request flow via User.http_client. |
pyproject.toml |
Bumps nicegui[native] minimum version to 3.10.0. |
uv.lock |
Lockfile update reflecting the NiceGUI version bump. |
| str(csv_path), | ||
| "--deadline", | ||
| (datetime.now(tz=UTC) + timedelta(seconds=5)).isoformat(), | ||
| (datetime.now(tz=UTC) + timedelta(seconds=60)).isoformat(), |
There was a problem hiding this comment.
The PR description says the run deadline is increased to 60 seconds, but this test now sets the deadline to 5 minutes. Please align the implementation with the PR description (e.g., use ~60 seconds) or update the PR description/title to match the 5-minute change.
| str(csv_path), | ||
| "--deadline", | ||
| (datetime.now(tz=UTC) + timedelta(seconds=5)).isoformat(), | ||
| (datetime.now(tz=UTC) + timedelta(seconds=60)).isoformat(), |
There was a problem hiding this comment.
The PR description says the run deadline is increased to 60 seconds, but this test now sets the deadline to 5 minutes. Please align the implementation with the PR description (e.g., use ~60 seconds) or update the PR description/title to match the 5-minute change.
| "fastapi[all,standard]>=0.123.10", | ||
| "humanize>=4.14.0,<5", | ||
| "nicegui[native]>=3.5.0,<4", # CVE-2026-21871, CVE-2026-21871, CVE-2026-21873, CVE-2026-21874 all require >=3.5.0 | ||
| "nicegui[native]>=3.10.0,<4", # CVE-2026-39844 |
There was a problem hiding this comment.
This PR is described as only increasing the run deadline for failing tests, but it also bumps the NiceGUI dependency (and updates uv.lock accordingly). Please reflect this additional change in the PR description/title (or split it into a separate PR) so reviewers and release notes can track the dependency/security update explicitly.
olivermeyer
force-pushed
the
test/increase-deadline
branch
from
aa13366 to
ab81598
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. |
Why?
test_cli_run_submit_succeeds_with_valid_pipeline_configandtest_cli_run_submit_succeeds_with_valid_a100_configfailed withValue error, deadline must not be in the past. This happens because the run is submitted with a deadline of 5 seconds; by the time we reach submission, those 5 seconds have passed.How?
This PR increases the run deadline to 60 seconds.