feat(otel): forward loguru extras to OTLP logs - #115
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
olivermeyer
force-pushed
the
feat/VPTHP-75-forward-loguru-extras-otlp
branch
from
August 20, 2026 14:16
3928bbf to
cfef7e8
Compare
olivermeyer
marked this pull request as ready for review
August 20, 2026 14:16
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
olivermeyer
force-pushed
the
feat/VPTHP-75-forward-loguru-extras-otlp
branch
from
August 20, 2026 14:44
cfef7e8 to
2ad5b8e
Compare
|
aig-hannes
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
foundry-core's OTLP log bridge dropped loguru's bound
extrafields, so cutting pviz's logs over to OTLP (VPTHP-75) would silently lose everylogger.bind()field —job_id,integration_type,queue,step. This foundry-core enhancement is Part A of that ticket and must ship before the pviz log cutover can land without regressing structured logging.How?
_make_otel_log_sinknow flattens eachrecord["extra"]field onto the constructed stdlibLogRecord.__dict__, so OTel'sLoggingHandlermaps every bound field to its own top-level OTLP log attribute rather than a nested dict; keys colliding with reservedLogRecordattributes are skipped so a bound field can never corrupt a record's standard fields.